release-20.1: pkg/storage: sync file in SafeWriteToFile #64498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `storage.SafeWriteToFile` did not guarantee that the file it wrote was synced to the storage media. Release note (bug fix): Fix a bug where encryption-at-rest metadata was not synced and might become corrupted during a hard reset.
|
This change is |
petermattis
approved these changes
May 1, 2021
complete! 1 of 0 LGTMs obtained
jbowens
commented
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64385.
Previously,
storage.SafeWriteToFiledid not guarantee that the file itwrote was synced to the storage media.
Release note (bug fix): Fix a bug where encryption-at-rest metadata was
not synced and might become corrupted during a hard reset.