release-20.1: ui: fix Overview screen in OSS builds #64126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This change is |
dhartunian
approved these changes
Apr 23, 2021
koorosh
force-pushed
the
backport20.1-56591
branch
from
86ae98e
to
281af92
Compare
nkodali
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @koorosh)
koorosh
force-pushed
the
backport20.1-56591
branch
from
281af92
to
153f65b
Compare
|
Closing due to issue with signing SLA. New PR will be created instead. |
|
The problem with SLA couldn't be solved with recreating another PR :( |
Previously, when using OSS builds (created with `make buildoss`), when you loading the DB Console in your browser, you'd get "Page Not Found". The route for the overview page was missing the leading '/'. This bug appears to have been introduced in 722c932. Release note (admin ui change): This fixes a bug where users of the OSS builds of CockroachDB would see "Page Not Found" when loading the Console.
koorosh
force-pushed
the
backport20.1-56591
branch
from
153f65b
to
885f9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #56591.
/cc @cockroachdb/release
Resolves #63376
Previously, when using OSS builds (created with
make buildoss), whenyou loading the DB Console in your browser, you'd get "Page Not Found".
The route for the overview page was missing the leading '/'. This bug
appears to have been introduced in
722c932.
Release note (admin ui change): This fixes a bug where users of
the OSS builds of CockroachDB would see "Page Not Found" when loading
the Console.