Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: unoptimized-query-oracle: incorrect zero oid handling in row-by-row hash joiner #123548

Closed
cockroach-teamcity opened this issue May 3, 2024 · 2 comments · Fixed by #123646
Closed

roachtest: unoptimized-query-oracle: incorrect zero oid handling in row-by-row hash joiner #123548

cockroach-teamcity opened this issue May 3, 2024 · 2 comments · Fixed by #123646
Assignees
@yuzefovich
Labels
branch-release-23.2 Used to mark GA and release blockers and technical advisories for 23.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator T-sql-queries SQL Queries Team
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 3, 2024 •
edited by cockroach-jira-scripts

roachtest.unoptimized-query-oracle/disable-rules=all/rand-tables failed with artifacts on release-23.2 @ 109656a0d65dd2e08935581f6876e9a70e110a24:

- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
- 	"0,0",
+ 	"0,-",
  }
sql: SELECT
	tab_98.col3_8 AS col_289, tab_97."{col1_0" AS col_290
FROM
	defaultdb.public.table1 AS tab_97 JOIN defaultdb.public.table3 AS tab_98 ON (tab_97."{col1_0") = (tab_98.col3_8)
ORDER BY
	tab_98.col3_8 NULLS LAST
test artifacts and logs in: /artifacts/unoptimized-query-oracle/disable-rules=all/rand-tables/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

This test on roachdash | Improve this report!

Jira issue: CRDB-38391
@cockroach-teamcity cockroach-teamcity added branch-release-23.2 Used to mark GA and release blockers and technical advisories for 23.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels May 3, 2024
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone May 3, 2024
@yuzefovich
Copy link
Member

Hm, this includes #123514, so seems like another edge case.

@yuzefovich yuzefovich removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label May 3, 2024
@yuzefovich
Copy link
Member

Reduced repro on 109656a:

CREATE TABLE table1 (col1 REGCLASS, INDEX (col1));
CREATE TABLE table3 (col3 OID, UNIQUE (col3));
INSERT INTO table1 VALUES (0);
INSERT INTO table3 VALUES (0);

SET vectorize = off;

SET testing_optimizer_random_seed = 5928357781746163642;
SET testing_optimizer_disable_rule_probability = 1.000000;

SELECT col1 FROM table1 JOIN table3 ON col1 = col3;

RESET testing_optimizer_random_seed;
RESET testing_optimizer_disable_rule_probability;

SELECT col1 FROM table1 JOIN table3 ON col1 = col3;

@yuzefovich yuzefovich self-assigned this May 3, 2024
@yuzefovich yuzefovich changed the title roachtest: unoptimized-query-oracle/disable-rules=all/rand-tables failed roachtest: unoptimized-query-oracle: incorrect zero oid handling in row-by-row hash joiner May 3, 2024
This was referenced May 4, 2024
Closed
Merged
@craig craig bot closed this as completed in 22b4a2c May 6, 2024
@blathers-crl blathers-crl bot mentioned this issue May 6, 2024
Merged
@yuzefovich yuzefovich mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-release-23.2 Used to mark GA and release blockers and technical advisories for 23.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. O-rsg Random Syntax Generator T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

rowexec: fix zero oid handling in hash joiner yuzefovich/cockroach
2 participants
@yuzefovich @cockroach-teamcity