Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: fix azure-event-hub uri syntactic sugar #123494

Open
rharding6373 opened this issue May 2, 2024 · 3 comments
Open

changefeedccl: fix azure-event-hub uri syntactic sugar #123494

rharding6373 opened this issue May 2, 2024 · 3 comments
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-easy Easy issue to tackle, requires little or no CockroachDB experience T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented May 2, 2024

24.1 docs suggest that users should be able to use the azure-event-hub prefix on their URIs as well as kafka, but although azure provides connection strings in a camelcase format SharedAccessKeyName=<...>;SharedAccessKey=<...>, CRDB current expects URIs prefixed with azure-event-hub to use snake case (e.g.,shared_access_key_name) for these parameters.

CDC should update the syntactic sugar around the azure-event-hub URI to support the format that azure provides to reduce friction for users and be consistent with documentation.

Jira issue: CRDB-38378

@rharding6373 rharding6373 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture T-cdc labels May 2, 2024
Copy link

blathers-crl bot commented May 2, 2024

cc @cockroachdb/cdc

@wenyihu6
Copy link
Contributor

wenyihu6 commented May 2, 2024

I think you just need to encode shared_access_key to get it working. I just tried on my end and it was working.

demo@127.0.0.1:26257/demoapp/movr> CREATE CHANGEFEED FOR TABLE a INTO
                                -> "azure-event-hub://wenyitest.servicebus.windows.net:9093?shared_access_key_name=RootManageSharedAccessKey&shared_access_key=redacted";
        job_id
----------------------
  965368103159988225
(1 row)

NOTICE: changefeed will emit to topic a
Time: 342ms total (execution 342ms / network 0ms)

@rharding6373 rharding6373 added the E-easy Easy issue to tackle, requires little or no CockroachDB experience label May 7, 2024
@rharding6373
Copy link
Collaborator Author

Leaving this issue open to address ease-of-use around the CamelCase vs snake_case. Since azure provides easy to copy connection strings in CamelCase, it would be ideal to support both syntaxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-easy Easy issue to tackle, requires little or no CockroachDB experience T-cdc
Projects
None yet
Development

No branches or pull requests

2 participants