Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor GetTotalMemoryWithoutLogging from github.com/cockroachdb/cockroach #166

Open
com6056 opened this issue Mar 14, 2023 · 4 comments
Open

Comments

@com6056
Copy link

com6056 commented Mar 14, 2023

Is there any chance we can get https://github.com/cockroachdb/cockroach/blob/7fe21a3b907aa148fcccc8ba62b9ac4db1ada50f/pkg/server/status/recorder.go#L644-L683 (and all child functions) vendored into this repo? Right now we have to copy over the code because importing github.com/cockroachdb/cockroach into our project isn't feasible. It would be great to have the same code that detects the memory usage available in this library since the testserver uses that value.

@ajwerner
Copy link

It seems like the real ask here is for us to make the cgroups library go-gettable as its own module, yeah?

@com6056
Copy link
Author

com6056 commented Mar 14, 2023

Sure, that works too!

@com6056
Copy link
Author

com6056 commented Dec 16, 2023

Any updates on this? Thanks!

@com6056
Copy link
Author

com6056 commented Apr 11, 2024

Friendly bump on this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants