Make it possible to configure maximum retry count #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
requested changes
Feb 8, 2022
| // WithMaxRetries configures context so that ExecuteTx retries tx specified | ||
| // number of times when encountering retryable errors. | ||
| // Setting retries to 0 will retry indefinitely. | ||
| func WithMaxRetries(ctx context.Context, retries int) context.Context { |
There was a problem hiding this comment.
could you add a basic test to verify something like
ctx = WithMaxRetries(ctx, n)
require.Equal(t, n, numRetriesFromContext(ctx)
executing transactions.
|
i've tagged this in release v2.2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to configure maximum retry count when executing transactions.