Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user errors.As for error type assertion #125

Merged
merged 1 commit into from Feb 8, 2022

Conversation

aeneasr
Copy link
Contributor

@aeneasr aeneasr commented Feb 2, 2022

Use proper error unstacking with Go's std libraries. The current code will only check for the first level of nesting whereas Go's std libraries are able to unpack several layers of wrapping.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss self-requested a review February 3, 2022 03:50
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@rafiss rafiss merged commit 3059636 into cockroachdb:master Feb 8, 2022
@aeneasr
Copy link
Contributor Author

aeneasr commented Feb 8, 2022

While I have you, if this change would warrant a release, I'd appreciate it :)

@rafiss
Copy link
Contributor

rafiss commented Feb 8, 2022

v2.2.7 has been released

@aeneasr
Copy link
Contributor Author

aeneasr commented Feb 8, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants