Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max retry error show correct message #123

Merged
merged 1 commit into from Jan 19, 2022
Merged

Make max retry error show correct message #123

merged 1 commit into from Jan 19, 2022

Conversation

rafiss
Copy link
Contributor

@rafiss rafiss commented Jan 18, 2022

Previously, it would just show the original cause of the retries, not
the message that says it is giving up on retrying.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

otan
otan approved these changes Jan 18, 2022
View reviewed changes
Copy link

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be cool if you could write a quick unit test for this one

@rafiss
Copy link
Contributor Author

rafiss commented Jan 19, 2022

added a test, tftr!

@rafiss rafiss merged commit 7a4e302 into cockroachdb:master Jan 19, 2022
@rafiss rafiss deleted the max-retry-error branch January 19, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

@ZhouXing19 ZhouXing19 Awaiting requested review from ZhouXing19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rafiss @cockroach-teamcity @otan