Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Use /var/tmp safely #12

Open
bdarnell opened this issue Mar 31, 2016 · 2 comments
Open

security: Use /var/tmp safely #12

bdarnell opened this issue Mar 31, 2016 · 2 comments

Comments

@bdarnell
Copy link
Member

In a multi-user system, the testserver binary could have been written by another user and may be malicious. We should include the username in the path (either in the filename or as an intermediate directory; I think a directory might be a little safer) and verify that ownership and permissions are as expected.

@benesch
Copy link
Contributor

benesch commented Apr 27, 2017

@bdarnell, should we perhaps use user cache dirs instead? I.e., $XDG_CACHE_HOME/cockroach (default $HOME/.cache/cockroach) on Unix, ~/Library/Caches/Cockroach on macOS, and %appdir%/Cockroach on Windows.

@bdarnell
Copy link
Member Author

Yeah, maybe. Dealing with platform-specific caching directories might be easier than dealing with long-term use of /tmp/.

justinj pushed a commit to justinj/cockroach-go that referenced this issue May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants