Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testserver: cmd with --log option does not generate listen-url in tests #109

Open
ZhouXing19 opened this issue Aug 11, 2021 · 0 comments
Open

Comments

@ZhouXing19
Copy link
Contributor

ZhouXing19 commented Aug 11, 2021

After replacing --logtostderr to --log="{file-defaults: {dir: tmp/dir/to/log}, sinks: {stderr: {filter: NONE}}}" , the "cockroach" command does not generate the listen-url file in the tmp directory when running tests from testserver_test.go. But the same command works well in local CLI.

Demo of tests with original --logtostderr running in debugger: check here
Demo of tests with --log running in debugger and local CLI: check here

Demos are based on these code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant