update README.md #107
update README.md #107
Conversation
There was a problem hiding this comment.
Hey @Marco2018
The change looks fines, but I'd suggest you do the following things:
- Go through the commit guidelines.
- Go through the newcomer's guide.
- After reading them, squash your commits.
- Modify your commit message as per the other examples given in the guidelines.
- Refer the issue in the PR description (its hard to follow the trail otherwise).
- Be sure to not make the changes from your master branch later on (it can lead to some complications). You don't need to change this for this PR though.
- Make all the changes in the current PR and don't create another one.
After all this is done, someone would merge your PR 🙂
|
Hi @shashank-b |
|
Hi @shashank-b |
There was a problem hiding this comment.
@Marco2018 Check coala git basics to know how can squashing of commits be done!
|
Hey! @KVGarg Thank you for your help. I have tried to squash my commits into one. So I reset back the branch and commit once again. It seems commits are squashed into one commit. Is it acceptable for this PR? So sorry I made this PR a little bit complicated. THX! |
avoid-->avoiding Closes coala#99
|
Yeah @Marco2018 |
|
@KVGarg Thanks! |
There was a problem hiding this comment.
Me likey! 👍🏻
Although you need a rebase or @abhishalya can do that & merge?
|
Won't be able to rebase as the PR was created from master. @Marco2018 please rebase if you can. |
README.md: Fix docstring typo
avoid -->avoiding
Closes #99