Add complex number data type in Python #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rajdeepbharati are you not supposed to add a commit message to this :) |
This adds complex_python data type. Closes coala#102
chay2199
reviewed
Mar 18, 2019
There was a problem hiding this comment.
Changes look good. But you have to follow coala commit guidelines and try to pass the tests that are failing.
siddhpant
suggested changes
Apr 1, 2019
BharathKumarRavichandran
suggested changes
Dec 10, 2020
There was a problem hiding this comment.
The code changes look good to me. Change the commit message to follow the coala commit standards and push again.
|
@BharathKumarRavichandran I'm closing this since I don't really use coala nowadays. You can go ahead and create a new PR if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds complex_python data type.
Closes #102