Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.4 rate limiter may be broken #62

Open
cnguy opened this issue Jan 10, 2019 · 2 comments
Open

v0.9.4 rate limiter may be broken #62

cnguy opened this issue Jan 10, 2019 · 2 comments

Comments

@cnguy
Copy link
Owner

cnguy commented Jan 10, 2019

After integrating this, #59, I did quick testing but didn't re-run all my examples to verify that the library still works properly. The hanging was solved, but batch promises don't seem to resolve via Promise.all.

For now stay on v0.9.3 or upgrade to v0.9.5 (they are the same things). v0.9.4 only introduces this hanging change.

What basically happens is the first promise of Promise.all will resolve, but the rest will not be resolved (in debug, the first request will be a success, while the rest are ignored, and then the process resolves).

For now I'll revert the change for v0.9.5 to prevent new install issues.

@cnguy cnguy added the bug label Jan 10, 2019
@jamesaps
Copy link

Any update on this?

@cnguy
Copy link
Owner Author

cnguy commented Jan 31, 2019

this will be revisited on the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants