Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Data Handling #57

Open
cnguy opened this issue Dec 18, 2018 · 0 comments
Open

Static Data Handling #57

cnguy opened this issue Dec 18, 2018 · 0 comments

Comments

@cnguy
Copy link
Owner

cnguy commented Dec 18, 2018

Tags proposed by user (Djinnes).

This issue will reimplement the old functionality provided by static data (tags) where the feature will do the following:

  • cache individual data by id + params (which can be defined as a URL)
// Flashback to KindredAPI code
const rakanConfig = {
  id: 497,
  options: {
    tags: ['image', 'sanitizedDescription']
  },
  region: REGIONS.BRAZIL
}

k.Static.champion(rakanConfig)
        .then(data => console.log(data))
        .catch(err => console.error(err))

I forgot what the resulting JSON loos like but you get the point

This issue needs rewriting

Before starting on this, it might be a good idea to have some example JSON outputs given some tags.
Note that version and locale used to be tags but is actually already implemented through DDragon urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant