Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"node.h" file not found error with Electron #45

Open
SpaceK33z opened this issue Feb 5, 2019 · 2 comments
Open

"node.h" file not found error with Electron #45

SpaceK33z opened this issue Feb 5, 2019 · 2 comments
Labels

Comments

@SpaceK33z
Copy link

I followed cmake-js's readme to add compatibility with Electron, but get the following error:

Scanning dependencies of target ref
[ 58%] Building CXX object deps/ref-cmake/CMakeFiles/ref.dir/__/ref/src/binding.cc.o
/Users/kees/dev/cmake-js-electron-error/node_modules/fastcall/deps/ref/src/binding.cc:5:10: fatal error: 'node.h' file not found
#include "node.h"
         ^~~~~~~~
1 error generated.
gmake[2]: *** [deps/ref-cmake/CMakeFiles/ref.dir/build.make:63: deps/ref-cmake/CMakeFiles/ref.dir/__/ref/src/binding.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1252: deps/ref-cmake/CMakeFiles/ref.dir/all] Error 2
gmake: *** [Makefile:152: all] Error 2
ERR! OMG Process terminated: 2

It seems Node header files are missing, but I don't know how to add this?

It's very easy to reproduce, just make a package.json file with the following contents:

{
  "name": "cmake-js-electron-error",
  "dependencies": {
    "electron": "^4.0.4",
    "fastcall": "^0.2.6"
  },
  "cmake-js": {
    "runtime": "electron",
    "runtimeVersion": "4.0.4"
  }
}

Previously reported in cmake-js/cmake-js#157

@unbornchikken
Copy link
Member

Fixing #44 will resolve it I think.

@adolfosilva
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants