You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey devs,
I'm not sure which part of cmake or cmake-js is actual responsible for this, I just try it here for a start:
We're developing project including llvm-bindings that leverages cmake-js, and that contributes native addons to node.js based on node-addon-api.
We have other dependencies that transitively pull NAN.
If NAN is contained in the (root level) node_modules folder, cmake fails with this error:
We can overcome this issue by ensuring that NAN is not hoisted to the root level node_modules, which feels hacky and I'm not sure whether further similar issues will come up.
Do you have any suggestions to solve this better?
The text was updated successfully, but these errors were encountered:
Hey devs,
I'm not sure which part of
cmake
orcmake-js
is actual responsible for this, I just try it here for a start:We're developing project including llvm-bindings that leverages
cmake-js
, and that contributes native addons to node.js based on node-addon-api.We have other dependencies that transitively pull NAN.
If NAN is contained in the (root level)
node_modules
folder,cmake
fails with this error:The location of failure is this: https://github.com/ApsarasX/llvm-bindings/blob/69c93f7aae697c3cb3e75d01e447554b0565e3d5/cmake/CMakeJS.cmake#L31
We can overcome this issue by ensuring that NAN is not hoisted to the root level
node_modules
, which feels hacky and I'm not sure whether further similar issues will come up.Do you have any suggestions to solve this better?
The text was updated successfully, but these errors were encountered: