Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep node headers in the include path even when node-addon-api is detected? #285

Open
remyjette opened this issue Oct 18, 2022 · 1 comment

Comments

@remyjette
Copy link

Prior to #278, headers for /include/node (or /src, /deps/v8/include, /deps/uv/include) would be included even when nan/node-addon-api were located.

Now, this seems to be an either-or situation.

My project mostly uses node-addon-api, but there's one location where we need uv.h. Could there be a way for us to specify that we do need the node headers too?

Thanks!

@Julusian
Copy link
Collaborator

Yeah, I am open to adding this as an opt-in thing, with some warnings about not being truely node version safe in the readme.

I don't know this code well enough yet to know if that can be defined as a parameter, or if it needs to be read from package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants