Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added iter methods to ObjectList #91

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Conversation

kitfre
Copy link

@kitfre kitfre commented Nov 21, 2019

Added iter and iter_mut methods to ObjectList to provide Iterators, as well as implementations of IntoIterator for ObjectList, &ObjectList and &mut ObjectList

#41

@clux
Copy link
Member

clux commented Nov 21, 2019

This is solid. Examples are really good, code is clean. Just a few typos in there that causes CI to fail atm.

Will definitely merge this when it passes, but I just have a small request:

change the pod_openapi.rs example to use the simpler iterator. it's currently doing a for p in pod.list().items.!


mod metadata;
pub use self::metadata::{
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add ListMeta to the public exports for use in the example in the docs on the new iter methods, is this okay or should I just cut out the examples?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should probably be public anyway 👍

thanks for pointing it out though. the re-formatting made that hard to spot.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@clux clux merged commit da71e21 into kube-rs:master Nov 21, 2019
@clux clux mentioned this pull request Nov 21, 2019
clux added a commit that referenced this pull request Nov 21, 2019
@clux
Copy link
Member

clux commented Nov 21, 2019

Released in kube 0.20.0 :-)

@kitfre kitfre deleted the objectlist-iter branch November 22, 2019 00:27
@kitfre
Copy link
Author

kitfre commented Nov 22, 2019

Awesome thanks! There's a good chance I pick at a couple other issues as well, rust and kuberentes are two of my favorite things and this project is awesome 🦀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants