Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 deprecation #35

Closed
bartvanhoutte opened this issue Dec 13, 2022 · 4 comments 路 Fixed by #43
Closed

PHP 8.2 deprecation #35

bartvanhoutte opened this issue Dec 13, 2022 · 4 comments 路 Fixed by #43

Comments

@bartvanhoutte
Copy link
Contributor

馃憢 Just discovered a deprecation using mq-react running on PHP 8.2.

Creation of dynamic property React\Promise\Deferred::$pending is deprecated in /var/www/vendor/clue/mq-react/src/Queue.php on line 432

Couple of ways to solve this:

  1. Add #[AllowDynamicProperties] in reactphp/promise v2 branch. Fast but might not be what we want.
  2. Add some sort of deferred/promise index in Queue. Quite a bit of work but clean.

What do you think?

@SimonFrings
Copy link
Collaborator

Hey @bartvanhoutte, good catch 馃憤

I think we can go a similar as @clue did in reactphp/http#459. As you said, it involves some work but seems to be the best way. I don't know when exactly we will get to implement this as we're currently working a lot on ReactPHP and the upcoming v3, but we also don't want to push this too far back because PHP 8.2 has already been released. If you want to give it a try we're always happy about PRs! 馃槈

@clue
Copy link
Owner

clue commented Jul 27, 2023

Closed via #43 :shipit:

@bartvanhoutte Thank you for reporting and the sparking this development with your initial PR! 馃憤

@clue clue closed this as completed Jul 27, 2023
@bartvanhoutte
Copy link
Contributor Author

@clue 馃憤 Didn't follow up because I don't know how to squash commits or something like that 馃槄

@clue
Copy link
Owner

clue commented Jul 27, 2023

@bartvanhoutte Don't worry, we're happy to help if you run into something like this next time. 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants