Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Can the checksum/SLSA provenance of the downloaded ArgoCD cli be verified? #25

Open
dannystaple opened this issue Oct 6, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file ⛱️ feature request Request for a new feature

Comments

@dannystaple
Copy link

dannystaple commented Oct 6, 2023

Is your feature request related to a problem? Please describe.
Supply chain injections are becoming a common security flaw in CI systems and build chains. This includes:

  • squatting in typo-named repos
  • where CI tools can be compromised, pushing tags/releases that masquerade as official ones
  • where repos have been renamed, or changed ownership, squatting in a previous repository name

Describe the solution you'd like

ArgoCD provides multiple mechanisms to validate the authenticity of the download, with SLSA and weaker SHA256 checksums available. Using one of these to verify the provenance of the intended version improves the integrity of using the dependancy.

This would be in the code to download ArgoCD for use by this action.

Using the SLSA method is preferred as it is more secure.

Describe alternatives you've considered
Using the simpler SHA256 mechanism. Performing these actions without using this repository.

Additional context
Add any other context or screenshots about the feature request here.

@dannystaple dannystaple changed the title Can the checksum/SLSA provenance of the downloaded ArgoCD cli be verified? Security: Can the checksum/SLSA provenance of the downloaded ArgoCD cli be verified? Oct 30, 2023
@bryantbiggs bryantbiggs added ⛱️ feature request Request for a new feature dependencies Pull requests that update a dependency file labels Oct 31, 2023
@bryantbiggs
Copy link
Member

Makes sense - we can look at adding this in, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ⛱️ feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants