Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support the ability to sense client disconnection #972

Closed
wants to merge 5 commits into from
Closed

feat: support the ability to sense client disconnection #972

wants to merge 5 commits into from

Conversation

chaoranz758
Copy link
Member

@chaoranz758 chaoranz758 commented Oct 16, 2023 •
edited

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: feat: support the ability to sense client disconnection
zh(optional):
支持感知客户端连接断开的能力

  1. 仅用于 netpoll
  2. 需要与 WithOnconnect 配合使用
  3. 开启后会有较大的开销

(Optional) Which issue(s) this PR fixes:

#855

(Optional) The PR that updates user documentation:

@chaoranz758 chaoranz758 requested review from a team as code owners October 16, 2023 03:01
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c0512ff) 81.82% compared to head (3259bcd) 81.83%.
Report is 3 commits behind head on develop.

❗ Current head 3259bcd differs from pull request most recent head 34ce7b2. Consider uploading reports for the commit 34ce7b2 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #972      +/-   ##
===========================================
+ Coverage    81.82%   81.83%   +0.01%     
===========================================
  Files           98       98              
  Lines         9926     9938      +12     
===========================================
+ Hits          8122     8133      +11     
  Misses        1314     1314              
- Partials       490      491       +1
Files Coverage Δ
pkg/app/server/option.go 98.79% <100.00%> (+0.02%) ⬆️
pkg/common/config/option.go 100.00% <100.00%> (ø)
pkg/network/netpoll/transport.go 88.40% <77.77%> (-5.15%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jin-gou li-jin-gou linked an issue Oct 16, 2023 that may be closed by this pull request
如何感知请求已结束？ #855
Open
@chaoranz758 chaoranz758 mentioned this pull request Nov 27, 2023
Closed
3 tasks
@welkeyever
Copy link
Member

Is this PR still in process/valid?

@chaoranz758
Copy link
Member Author

Is this PR still in process/valid?

This PR should be able to close, hertz cannot solve this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

如何感知请求已结束？
3 participants
@chaoranz758 @welkeyever @li-jin-gou