Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OnAccept panic #514

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Jan 5, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

OnAccept 方法在标准库下会 panic

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: OnAccept panic when use standard library
zh(optional): OnAccept 方法在标准库下会 panic

Which issue(s) this PR fixes:

close #507

Sorry, something went wrong.

@Duslia Duslia requested review from a team as code owners January 5, 2023 02:48
@Duslia Duslia force-pushed the fix/onaccept_panic branch from e6db42b to 7288702 Compare January 5, 2023 02:49
@Duslia
Copy link
Member Author

Duslia commented Jan 5, 2023

#507

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 69.38% // Head: 69.39% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7288702) compared to base (16de10c).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #514      +/-   ##
===========================================
+ Coverage    69.38%   69.39%   +0.01%     
===========================================
  Files           93       93              
  Lines         8874     8874              
===========================================
+ Hits          6157     6158       +1     
+ Misses        2352     2351       -1     
  Partials       365      365              
Impacted Files Coverage Δ
pkg/common/config/option.go 100.00% <ø> (ø)
pkg/network/netpoll/transport.go 0.00% <ø> (ø)
pkg/network/standard/transport.go 0.00% <0.00%> (ø)
pkg/app/server/option.go 95.77% <100.00%> (ø)
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou
Copy link
Member

LGTM

@li-jin-gou li-jin-gou merged commit e0f24ce into cloudwego:develop Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

error addr := conn.LocalAddr().String() //:796
3 participants