Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some problem about "hz update" #1116

Closed
ChinaPhpZyp opened this issue May 15, 2024 · 3 comments
Closed

Some problem about "hz update" #1116

ChinaPhpZyp opened this issue May 15, 2024 · 3 comments
Labels
question Further information is requested

Comments

@ChinaPhpZyp
Copy link

Describe the Question

A clear and concise description of what the question is.

Expected behavior

Steps to reproduce the behavior:

  1. At first, we have a service called "getCustomerMessageList" with route is "/seller/customer/message/list" . The route have the function for middle is "message0Mv()"
  2. Some time later, the other teammate write a service called "userAndCustomerList" with route is "/message/customer".
  3. The getCustomerMessageList's router will change to bind "message1Mv()", and "message0Mv()" will be bind by the userAndCustomerList.
  4. Then the route will be useless because the middleware is Auth Validate

I just want to ask some ways to deal this . Maybe the "thirft" file can support to wirte the relation of the route and the middleware

Screenshots

func _message0Mw() []app.HandlerFunc {
	return nil
}

func _message2Mw() []app.HandlerFunc {
	// your code...
	return []app.HandlerFunc{
		jwt.JWTAuth(config.GlobalServerConfig.JWTInfo.SigningKey),
	}
}

Hertz version:

hz version v0.8.1

@li-jin-gou
Copy link
Member

cc @FGYFFFF

@li-jin-gou li-jin-gou added the question Further information is requested label May 16, 2024
@FGYFFFF
Copy link
Contributor

FGYFFFF commented May 16, 2024

@ChinaPhpZyp
这个可能是由于解析 "路由树" 时没有严格排序带来的极端case
在最新版本,我们加入了一个新的选项 "-sort_router",他会对路由树进行严格的排序,确保你每次 update 后的路由都是确定的,避免随机性。 但是他可能会对当前的 router.go 的格式带来一些变化,但是不会影响路由注册的正确性

@ChinaPhpZyp
Copy link
Author

@FGYFFFF 好的,感觉解答,更新到v0.9版本后看到了这个选项,我们后续持续观测一下

@ChinaPhpZyp ChinaPhpZyp closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

3 participants