Skip to content

Include updates to exports/context.tf #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 4, 2021
Merged

Include updates to exports/context.tf #122

merged 5 commits into from
Feb 4, 2021
+31 −32

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 4, 2021 •
edited
Loading

what

  • Include updates to exports/context.tf
  • Update README with features and compatibilty
  • Add validation for id_length_limit

why

  • The exports/context.tf is what gets distributed and needs to be in sync
  • Replace outdated information
  • Was not validated earlier because validators are not supported in TF 0.12 but now we are dropping support for TF 0.12 and so we can add validators

@Nuru Nuru requested a review from a team as a code owner February 4, 2021 08:40
@Nuru
Copy link
Contributor Author

Nuru commented Feb 4, 2021

/test all

osterman
osterman previously approved these changes Feb 4, 2021
View reviewed changes
@Nuru
Copy link
Contributor Author

Nuru commented Feb 4, 2021

/test all

@Nuru Nuru requested a review from osterman February 4, 2021 08:49
osterman
osterman previously approved these changes Feb 4, 2021
View reviewed changes
@Nuru
Copy link
Contributor Author

Nuru commented Feb 4, 2021

/test all

osterman
osterman reviewed Feb 4, 2021
View reviewed changes
@Nuru @osterman
Fix validation test syntax

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
44458c0 
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
@Nuru
Copy link
Contributor Author

Nuru commented Feb 4, 2021

/test all

@Nuru Nuru requested a review from osterman February 4, 2021 08:56
@Nuru Nuru merged commit 3a7014c into master Feb 4, 2021
@Nuru Nuru deleted the readme branch February 4, 2021 08:59
@Nuru Nuru mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nuru @osterman