Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to reflect that codestar is now preferred for github sources #78

Closed
wants to merge 2 commits into from

Conversation

inhumantsar
Copy link
Contributor

what

  • Updated docs and resource names to reflect the fact that Codestar connections are now AWS's preferred source option

why

  • To avoid giving users the impression that the older, slightly more risky option is the only one available for GitHub sources.

references

@nitrocode
Copy link
Member

I don't think we should change the names of the resources as that would cause recreations of resources which breaks backwards compatibility.

@inhumantsar
Copy link
Contributor Author

backwards compatibility doesn't seem like it's much of a concern in other modules though? major changes to input vars on other cloudposse repos get the release labelled as a breaking change and put out with a minor version bump. eg: https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/releases/tag/0.57.0

these changes don't even change the input vars. it would trigger a rebuild yes, but it also wouldn't require code changes on the user's part.

since this is a permanent change in the way aws treats github repos going forward, i think that getting prepared for a move away from webhooks being the default would be good to do before it becomes a last minute thing.

@mergify
Copy link

mergify bot commented Nov 5, 2021

This pull request is now in conflict. Could you fix it @inhumantsar? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GitHub (Version 2)/CodeStar Source
3 participants