Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub (Version 2)/CodeStar Source #51

Open
ses4j opened this issue Nov 6, 2020 · 2 comments
Open

Support GitHub (Version 2)/CodeStar Source #51

ses4j opened this issue Nov 6, 2020 · 2 comments

Comments

@ses4j
Copy link

ses4j commented Nov 6, 2020

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Slack Community

Describe the Feature

Code Pipeline source provider GitHub Version 2 is the current preferred GitHub connection, using GitHub Apps rather than OAuth.

Expected Behavior

Support GitHub Version 2 source.

@ses4j
Copy link
Author

ses4j commented Nov 6, 2020

Possibly this is simply a documentation thing, as the existing bitbucket/codestar support might work. Specifically, NOT settings github_oauth_token and settings codestar_connection_arn instead.

@brettflorio
Copy link

brettflorio commented Jul 6, 2021

Possibly this is simply a documentation thing, as the existing bitbucket/codestar support might work. Specifically, NOT settings github_oauth_token and settings codestar_connection_arn instead.

@ses4j In the context of aws-ecs-web-app, at least, this doesn't seem to be the case. Removing/replacing codepipeline_github_oauth_token with codepipeline_codestar_connection_arn (or codestar_connection_arn) results in pipeline being removed entirely. (Adding it without removing the github_oauth_token results in no applied changes.)

EDIT: After a little bit of poking, I think you're right. The ecs-web-app repo just needs a little tidying. I'll submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants