Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress ... #63

Closed
wants to merge 2 commits into from
Closed

Conversation

apanzerj
Copy link
Sponsor

@apanzerj apanzerj commented Oct 30, 2022

WIP to fix #62

Notes: This seems to work but I need to test it further.

Expected entries:

testing.domain.bunny-internal.com
cname: _bb25fcae8aa1307005f50002610ced1e.testing.domain.bunny-internal.com.
cname value: _0ead46f553ceef8f8ddfe8c947fd8e41.wdrzrjwmwn.acm-validations.aws.

*.testing.domain.bunny-internal.com
cname: _bb25fcae8aa1307005f50002610ced1e.testing.domain.bunny-internal.com.
cname value: _0ead46f553ceef8f8ddfe8c947fd8e41.wdrzrjwmwn.acm-validations.aws.

*.bunny-internal.com
cname: _c3a24f885f545b59d0b6042afb5066e6.bunny-internal.com.
cname value: _854a8eea6a03511395522b6d09c1496f.fpktwqqglf.acm-validations.aws.

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

@apanzerj apanzerj requested review from a team as code owners October 30, 2022 20:07
@apanzerj apanzerj marked this pull request as draft October 30, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This PR has gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosing the right zone for each SAN when attaching validation records
3 participants