Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify artifact name #44

Open
TheBatman09 opened this issue Mar 7, 2024 · 3 comments · May be fixed by #45
Open

Allow user to specify artifact name #44

TheBatman09 opened this issue Mar 7, 2024 · 3 comments · May be fixed by #45
Assignees

Comments

@TheBatman09
Copy link

Use Case

Hello guys, I've started using this action and I came across the following issue: I have some dynamically retrieved data that I write with a step name and a matrix name. Then I retrieve some data again and try to write it with a different step name but same matrix name. And here when the data is the same for first and second time I get an error saying the artifact already exists. By looking at the code it looks like that's because the artifact name used is a hash of the content and in my case the content is the same in both cases.

Expected Behavior

I expect to be able to write the same data twice with a different step name.

Describe Ideal Solution

I think the ideal solution would be to add a parameter to the action to allow the user to chose the key used to store the artifact and/or also include the step name in the hash to allow storing twice the same data if it has a different step name.

Bonus

It seems like a fairly easy fix, i'd be happy to contribute if needed

@TheBatman09 TheBatman09 changed the title Allow customer to specify artifact name Allow user to specify artifact name Mar 7, 2024
@goruha goruha self-assigned this Mar 7, 2024
@TheBatman09
Copy link
Author

Hey @goruha If you'd like I could propose a pull request for this 😉

@goruha
Copy link
Member

goruha commented Mar 20, 2024

@TheBatman09, thanks for the feature request.
Your PR is more than welcome.

@TheBatman09 TheBatman09 linked a pull request Mar 20, 2024 that will close this issue
@TheBatman09
Copy link
Author

Voila !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants