feat: specify artifact name #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBatman09
commented
Mar 20, 2024
| @@ -74,7 +78,7 @@ ${error}`; | |||
| const hex = hashSum.digest('hex'); | |||
|
|
|||
| const artifactClient = new DefaultArtifactClient(); | |||
| const artifactName = hex; | |||
| const artifactName = isEmptyInput(artifact_name) ? hex : artifact_name + matrix_key; | |||
There was a problem hiding this comment.
I hesitated here to rename the artifactName const to something else to differentiate them. However since I noticed inputs are in snake case, I thought maybe that's your convention to differentiate inputs form the rest and that's enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
An optional input
artifact-nameis added to allow the user to specify how to name the artifacts stored.If the input is missing, the hash is used as before.
why
Due to the use of a hash of the content as an artifact name, if different steps (with a different step name) try to use the action to write the same content, the build will fail. The first step will succeed but the second one will fail because an artifact with the same name already exists.
references
Fixes #44