Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a destroy command to the wrapper script to support removing the currently running geodesic container #798

Open
Gowiem opened this issue Sep 7, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Gowiem
Copy link
Member

Gowiem commented Sep 7, 2022

Describe the Feature

It would be great to have a geodesic destroy or similar command to remove the currently running image.

Use Case

This would help in clearing the existing container in the case that the user no longer wants it around.

Describe Ideal Solution

geodesic destroy would lookup the running geodesic container ID and issue a docker rm $CONTAINER_ID against it.

Alternatives Considered

N/A

Additional Context

N/A

@Nuru
Copy link
Sponsor Contributor

Nuru commented Nov 7, 2022

I am inclined to close/refuse this request, because it seems to me to be a scary option, because it terminates all running shells without doing cleanup like saving shell history.

You can specify a container by name in the Docker CLI, e.g.

docker rm -f geodesic

which both seems to be easy enough to not warrant adding a separate Geodesic command and avoids Cloud Posse advocating or supporting such behavior.

@osterman
Copy link
Member

I like the option. And if it's scary, then default to a prompt =)

Geodesic should be self-contained, and explaining other commands like calling docker directly should be avoided and considered workarounds.

@osterman osterman added the help wanted Extra attention is needed label Nov 17, 2022
@Nuru
Copy link
Sponsor Contributor

Nuru commented Feb 12, 2024

@Gowiem @osterman I'm a little unclear about what you want.

We recommend using the installed wrapper, which automatically removes the container image on termination, and has commands

  • stop to stop the running Geodesic image
  • uninstall to delete the Geodesic container and image (although it does not delete the wrapper itself)

If not using the installed wrapper, you can remove the container automatically with the --rm option to docker run.

If not using the installed wrapper and not using --rm, I am not sure how we can help you. Please elaborate.

@settings settings bot removed the feature request label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants