Improve terraform import. Add help for all atmos commands
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
Dec 21, 2021
| configAndStacksInfo.NeedHelp = argsAndFlagsInfo.NeedHelp | ||
|
|
||
| // Check if `-h` or `--help` flags are specified | ||
| if argsAndFlagsInfo.NeedHelp == true { |
There was a problem hiding this comment.
Suggested change
| if argsAndFlagsInfo.NeedHelp == true { | |
| if argsAndFlagsInfo.NeedHelp { |
There was a problem hiding this comment.
yea, nice find.
it's opinionated since Go is a very explicit language
nitrocode
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
terraform importatmoscommandswhy
Since
terraform importcommand requires a region,atmos terraform importlooks forregionin the variables for the specified component and stack, and if it finds it, setsAWS_REGION=<region>ENV var before executing the commandHelp needed for all
atmoscommands and subcommandsrelated
test
atmos --help
atmos terraform --help
atmos terraform plan --help
atmos helmfile --help
atmos helmfile diff --help