Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to install customized quickstart image #490

Open
patlachance opened this issue Dec 16, 2023 · 0 comments
Open

unable to install customized quickstart image #490

patlachance opened this issue Dec 16, 2023 · 0 comments
Labels
bug 🐛 An issue with the system

Comments

@patlachance
Copy link
Contributor

Describe the Bug

Tried to change the DOCKER_ORG, DOCKER_IMAGE and DOCKER_TAG in the Makefile file, build the container and then install it using make install but it tries installing the cloudposse/atmos image instead of the customized one.

Expected Behavior

Running make install should install by customized image

Steps to Reproduce

Clone the repo, patch the Makefile and build the container image

$ git clone
$ cd examples/quickstart
$ sed -i -e 's/DOCKER_ORG ?= cloudposse/DOCKER_ORG ?= myorg/' Makefile
$ sed -i -e 's/DOCKER_IMAGE ?= $(DOCKER_ORG)\/atmos/DOCKER_IMAGE ?= $(DOCKER_ORG)\/myatmos/' Makefile
$ make init build

Try to install the image

$ make install
# Installing newatmos from cloudposse/atmos:latest...
Unable to find image 'cloudposse/atmos:latest' locally
docker: Error response from daemon: pull access denied for cloudposse/atmos, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.

# Failed to install newatmos
# If this is not due to file system permissions, please
# check for known issues and consider reporting the failure at
#    https://github.com/cloudposse/geodesic/issues

Try: sudo make install
make: *** [Makefile:35: install] Error 1

==> The default cloudposse/atmos image is used instead of the customized one.

Changing the following section of the Makefile from

install:
	@docker run --rm $(DOCKER_IMAGE_NAME) | bash -s $(DOCKER_TAG) || (echo 

to

install:
	@docker run --rm -e DOCKER_IMAGE -e DOCKER_TAG $(DOCKER_IMAGE_NAME) | bash -s $(DOCKER_TAG) || (echo 

will fix the issue, I'll provide a pull request soon.

Screenshots

No response

Environment

No response

Additional Context

No response

@patlachance patlachance added the bug 🐛 An issue with the system label Dec 16, 2023
patlachance added a commit to patlachance/atmos that referenced this issue Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

1 participant