Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow unknown flags when unnecessary #290

Merged
merged 3 commits into from Jan 1, 2023
Merged

Do not allow unknown flags when unnecessary #290

merged 3 commits into from Jan 1, 2023

Conversation

stoned
Copy link
Contributor

@stoned stoned commented Jan 1, 2023

what

  • Report unknown flags given to relevant commands

why

  • IMHO it causes less surprise to report unknown flags

@stoned stoned requested review from a team as code owners January 1, 2023 14:07
@cloudpossebot cloudpossebot requested a review from a team as a code owner January 1, 2023 14:08
@aknysh aknysh merged commit 3a43ea0 into cloudposse:master Jan 1, 2023
@stoned stoned deleted the strict-args branch January 1, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stoned @aknysh @cloudpossebot