Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate error message output #289

Merged
merged 2 commits into from Jan 1, 2023
Merged

Avoid duplicate error message output #289

merged 2 commits into from Jan 1, 2023

Conversation

stoned
Copy link
Contributor

@stoned stoned commented Jan 1, 2023

what

  • The Execute*Cmd() functions do not need to print a possible error message from cfg.InitCliConfig() as their callers already do that.

why

@stoned
Avoid duplicate error message output
1e9f310 
... as the functions calling Execute*Cmd() display any error from
InitCliConfig() before exiting.
@stoned stoned requested review from a team as code owners January 1, 2023 14:03
@cloudpossebot cloudpossebot requested a review from a team as a code owner January 1, 2023 14:04
aknysh
aknysh approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @stoned

@aknysh aknysh merged commit 3b62c54 into cloudposse:master Jan 1, 2023
@stoned stoned deleted the avoid-dup-errmsg branch January 1, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stoned @aknysh @cloudpossebot