Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump homebrew if build succeeds #286

Merged
merged 1 commit into from Dec 31, 2022
Merged

Bump homebrew if build succeeds #286

merged 1 commit into from Dec 31, 2022

Conversation

nitrocode
Copy link
Member

what

  • Bump homebrew if build succeeds

why

  • If the build doesn't succeed, do not bump homebrew
  • This came up when v1.19.0 failed and homebrew was incorrectly bumped

references

@nitrocode nitrocode requested review from a team as code owners December 30, 2022 23:39
@nitrocode nitrocode added the no-release Do not create a new release (wait for additional code changes) label Dec 30, 2022
@aknysh aknysh merged commit d1a3a8a into master Dec 31, 2022
@aknysh aknysh deleted the bump-homebrew-if-build-succeeds branch December 31, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nitrocode @aknysh