New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting ATMOS_CLI_CONFIG_PATH
to a file path and not a directory path causes a panic
#191
Comments
@Gowiem thanks. |
@Gowiem so try changing export ATMOS_CLI_CONFIG_PATH=/mnt/workspace/source/rootfs/usr/local/etc/atmos/atmos.yaml to export ATMOS_CLI_CONFIG_PATH=/mnt/workspace/source/rootfs/usr/local/etc/atmos/ |
@aknysh @nitrocode yeah, we figured that out quickly and resolved the problem. I'm raising this issue because it shouldn't cause a panic and segfault with the above stacktrace -- We should instead get a nice error saying something along the following:
That's all 😄 |
thank you @Gowiem , we'll improve it |
* fix: updates file_utils#FileExists to check for err (#191) * chore: adds `atmos.yaml` to error message Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com> Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Describe the Bug
We set
ATMOS_CLI_CONFIG_PATH
to/mnt/workspace/source/rootfs/usr/local/etc/atmos/atmos.yaml
and it resulted in the following:Expected Behavior
We would expect a graceful failure instead of a panic.
Steps to Reproduce
Steps to reproduce the behavior:
ATMOS_CLI_CONFIG_PATH
to a direct path to theatmos.yaml
file instead of a directory.atmos terraform plan
Screenshots
N/A
Environment (please complete the following information):
Additional Context
cc @joe-niland
The text was updated successfully, but these errors were encountered: