Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update atmos vendor pull #186

Merged
merged 4 commits into from Aug 25, 2022
Merged

Update atmos vendor pull #186

merged 4 commits into from Aug 25, 2022

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Aug 24, 2022

what

  • Update atmos vendor pull

why

  • Allow using absolute and relative file paths in component.yaml when vendoring mixins. This will allow having mixins in a local folder (and not in a private GitHub repo for which you'll have to use a GitHub token or other means to authenticate)
  # mixins override files from 'source' with the same 'filename' (e.g. 'context.tf' will override 'context.tf' from the 'source')
  # mixins are processed in the order they are declared in the list
  mixins:
    # Mixins 'uri' supports the following protocols: local files (absolute and relative paths), Git, Mercurial, HTTP, HTTPS, Amazon S3, Google GCP
    # This mixin `uri` is relative to the current `vpc-flow-logs-bucket` folder
    - uri: ../../mixins/context.tf
      filename: context.tf
    - uri: https://raw.githubusercontent.com/cloudposse/terraform-aws-components/{{.Version}}/modules/datadog-agent/introspection.mixin.tf
      version: 0.196.1
      filename: introspection.mixin.tf

related

@aknysh aknysh self-assigned this Aug 24, 2022
@aknysh aknysh requested review from a team as code owners August 24, 2022 18:29
@aknysh aknysh requested a review from RothAndrew August 24, 2022 18:29
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

examples/complete/Dockerfile Show resolved Hide resolved
examples/complete/Dockerfile Show resolved Hide resolved
@aknysh aknysh merged commit 337c965 into master Aug 25, 2022
@aknysh aknysh deleted the implement-diff branch August 25, 2022 01:36
@Gowiem
Copy link
Member

Gowiem commented Aug 25, 2022

@aknysh awesome turn around time from me raising this issue in #185 -- Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atmos vendor pull + component.yaml mixins should support relative paths
3 participants