Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base_path setting to atmos config #100

Merged
merged 12 commits into from Jan 10, 2022
Merged

Add base_path setting to atmos config #100

merged 12 commits into from Jan 10, 2022

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jan 10, 2022

what

  • Add base_path setting to atmos config
  • Add atmos logos
  • Update README

why

  • Provide/configure a base path for all components and stacks
  • Allow controlling stacks and components paths using only one setting or ENV var
  • Can also be set using ATMOS_BASE_PATH ENV var, or --base-path command-line argument
  • Supports both absolute and relative paths
  • If not provided or is an empty string, components.terraform.base_path, components.helmfile.base_path and stacks.base_pathare independent settings (supporting both absolute and relative paths)
  • If base_path is provided (via ENV var or command-line arg), components.terraform.base_path, components.helmfile.base_path and stacks.base_path are considered paths relative to base_path

test

ATMOS_BASE_PATH=./examples/complete atmos terraform apply test/test-component -s=tenant1-ue2-dev
Found ENV var ATMOS_BASE_PATH=./examples/complete

Variables for the component 'test/test-component' in the stack 'tenant1/ue2/dev':

enabled: true
environment: ue2
namespace: eg
region: us-east-2
service_1_name: service-1
service_2_name: service-2
stage: dev
tenant: tenant1

Writing variables to file:
examples/complete/components/terraform/test/test-component/tenant1-ue2-dev-test-component.terraform.tfvars.json

@aknysh aknysh added the patch A minor, backward compatible change label Jan 10, 2022
@aknysh aknysh self-assigned this Jan 10, 2022
@aknysh aknysh requested review from a team as code owners January 10, 2022 04:04
nitrocode
nitrocode previously approved these changes Jan 10, 2022
@nitrocode
Copy link
Member

Is this new atmos logo in creative commons ?

@nitrocode
Copy link
Member

Does this close PR #96 ?

@aknysh
Copy link
Member Author

aknysh commented Jan 10, 2022

Does this close PR #96 ?

No, it's a diff thing (providing paths to the code via inputs, not reading them from atmos.yaml)

README.yaml Show resolved Hide resolved
README.yaml Show resolved Hide resolved
README.yaml Outdated Show resolved Hide resolved
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
aknysh and others added 4 commits January 10, 2022 10:57
Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants