From 3b62c54c50051d717ab4b1079cfcd0d5f8c55f1a Mon Sep 17 00:00:00 2001 From: stoned Date: Sun, 1 Jan 2023 16:47:17 +0100 Subject: [PATCH] Avoid duplicate error message output (#289) * Avoid duplicate error message output ... as the functions calling Execute*Cmd() display any error from InitCliConfig() before exiting. * Auto Format Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com> --- README.md | 2 +- internal/exec/describe_affected.go | 1 - internal/exec/describe_stacks.go | 1 - internal/exec/helmfile.go | 1 - internal/exec/terraform.go | 1 - internal/exec/terraform_generate_backend.go | 1 - internal/exec/terraform_generate_backends.go | 1 - internal/exec/terraform_generate_varfile.go | 1 - internal/exec/terraform_generate_varfiles.go | 1 - internal/exec/validate_component.go | 1 - 10 files changed, 1 insertion(+), 10 deletions(-) diff --git a/README.md b/README.md index 1a118a3a2..4dcd0711e 100644 --- a/README.md +++ b/README.md @@ -186,7 +186,7 @@ In general, PRs are welcome. We follow the typical "fork-and-pull" Git workflow. ## Copyright -Copyright © 2017-2022 [Cloud Posse, LLC](https://cpco.io/copyright) +Copyright © 2017-2023 [Cloud Posse, LLC](https://cpco.io/copyright) diff --git a/internal/exec/describe_affected.go b/internal/exec/describe_affected.go index 9f04fe689..c6c36b995 100644 --- a/internal/exec/describe_affected.go +++ b/internal/exec/describe_affected.go @@ -24,7 +24,6 @@ func ExecuteDescribeAffectedCmd(cmd *cobra.Command, args []string) error { cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/describe_stacks.go b/internal/exec/describe_stacks.go index 4c73f3c4c..c1b57bbff 100644 --- a/internal/exec/describe_stacks.go +++ b/internal/exec/describe_stacks.go @@ -19,7 +19,6 @@ func ExecuteDescribeStacksCmd(cmd *cobra.Command, args []string) error { cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/helmfile.go b/internal/exec/helmfile.go index 0a0f7d193..3cc3003b8 100644 --- a/internal/exec/helmfile.go +++ b/internal/exec/helmfile.go @@ -22,7 +22,6 @@ func ExecuteHelmfileCmd(cmd *cobra.Command, args []string) error { cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/terraform.go b/internal/exec/terraform.go index 115b30913..191173aa6 100644 --- a/internal/exec/terraform.go +++ b/internal/exec/terraform.go @@ -25,7 +25,6 @@ func ExecuteTerraformCmd(cmd *cobra.Command, args []string) error { cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/terraform_generate_backend.go b/internal/exec/terraform_generate_backend.go index 23aa4b965..77f9e11af 100644 --- a/internal/exec/terraform_generate_backend.go +++ b/internal/exec/terraform_generate_backend.go @@ -36,7 +36,6 @@ func ExecuteTerraformGenerateBackendCmd(cmd *cobra.Command, args []string) error cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/terraform_generate_backends.go b/internal/exec/terraform_generate_backends.go index b6e9b0a61..82afaef49 100644 --- a/internal/exec/terraform_generate_backends.go +++ b/internal/exec/terraform_generate_backends.go @@ -20,7 +20,6 @@ func ExecuteTerraformGenerateBackendsCmd(cmd *cobra.Command, args []string) erro cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/terraform_generate_varfile.go b/internal/exec/terraform_generate_varfile.go index c4fc3673f..10b62757a 100644 --- a/internal/exec/terraform_generate_varfile.go +++ b/internal/exec/terraform_generate_varfile.go @@ -35,7 +35,6 @@ func ExecuteTerraformGenerateVarfileCmd(cmd *cobra.Command, args []string) error cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/terraform_generate_varfiles.go b/internal/exec/terraform_generate_varfiles.go index 0f17cb2ff..4ac831e43 100644 --- a/internal/exec/terraform_generate_varfiles.go +++ b/internal/exec/terraform_generate_varfiles.go @@ -20,7 +20,6 @@ func ExecuteTerraformGenerateVarfilesCmd(cmd *cobra.Command, args []string) erro cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err } diff --git a/internal/exec/validate_component.go b/internal/exec/validate_component.go index 6f6bcf35a..23ac62edf 100644 --- a/internal/exec/validate_component.go +++ b/internal/exec/validate_component.go @@ -21,7 +21,6 @@ func ExecuteValidateComponentCmd(cmd *cobra.Command, args []string) error { cliConfig, err := cfg.InitCliConfig(info, true) if err != nil { - u.PrintErrorToStdError(err) return err }