Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest no longer bundles py #487

Closed
frenzymadness opened this issue Nov 11, 2022 · 4 comments
Closed

pytest no longer bundles py #487

frenzymadness opened this issue Nov 11, 2022 · 4 comments

Comments

@frenzymadness
Copy link
Contributor

py is kinda deprecated and pytest now bundles only a subset of it. It'd be best to stop depending on it. If it's not possible, dependency on py should be explicitly specified so the original package is installed.

@stanislavlevin
Copy link

https://docs.pytest.org/en/latest/changelog.html#pytest-7-2-0-2022-10-23:

#10396: pytest no longer depends on the py library. pytest provides a vendored copy of py.error and py.path modules but will use the py library if it is installed. If you need other py.* modules, continue to install the deprecated py library separately, otherwise it can usually be removed as a dependency.

The affected test of cloudpickle relies on py package that previously was indirectly pulled into tests environment as pytest's dependency.

@frenzymadness
Copy link
Contributor Author

And it seems that it has been there only for Python 2 compatibility which is not available in py since 2019.

@ogrisel
Copy link
Contributor

ogrisel commented Jan 18, 2023

Thanks, this was fixed in #494.

@ogrisel ogrisel closed this as completed Jan 18, 2023
@ogrisel
Copy link
Contributor

ogrisel commented Jan 18, 2023

And it seems that it has been there only for Python 2 compatibility which is not available in py since 2019.

I missed that. Feel free to open a follow-up PR to completely delete this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants