Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Support PyPy > 3.7 #480

Merged
merged 7 commits into from Sep 7, 2022
Merged

FIX: Support PyPy > 3.7 #480

merged 7 commits into from Sep 7, 2022

Conversation

lesteve
Copy link
Contributor

@lesteve lesteve commented Sep 7, 2022

Take over and close #461.

Fix #477.

@lesteve lesteve changed the title Fix import of pickle module on PYPY 3.8 (#455) FIX: Support PyPy > 3.7 Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #480 (60bd181) into master (f5472e1) will decrease coverage by 0.96%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   92.60%   91.64%   -0.97%     
==========================================
  Files           4        4              
  Lines         717      718       +1     
  Branches      158      159       +1     
==========================================
- Hits          664      658       -6     
- Misses         32       37       +5     
- Partials       21       23       +2     
Impacted Files Coverage Δ
cloudpickle/compat.py 100.00% <ø> (ø)
cloudpickle/cloudpickle_fast.py 95.41% <100.00%> (-1.52%) ⬇️
cloudpickle/cloudpickle.py 88.06% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for the fix!

CHANGES.md Outdated Show resolved Hide resolved
@ogrisel ogrisel merged commit 23cbe15 into cloudpipe:master Sep 7, 2022
@lesteve lesteve deleted the fix-pypy38 branch September 7, 2022 16:02
@mattip
Copy link

mattip commented Sep 8, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPy 3.8 and PyPy 3.9 enter infinite recursive loop
4 participants