Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream CI #471

Merged
merged 6 commits into from May 20, 2022
Merged

Fix downstream CI #471

merged 6 commits into from May 20, 2022

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented May 20, 2022

  • bump up the python version used to run those tests;
  • add a missing dependencies (aiohttp and pyarrow) for distributed.

@ogrisel ogrisel added the ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects. label May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #471 (72b6f61) into master (f758eb3) will decrease coverage by 8.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   92.58%   84.47%   -8.12%     
==========================================
  Files           4        4              
  Lines         715      715              
  Branches      159      157       -2     
==========================================
- Hits          662      604      -58     
- Misses         32       87      +55     
- Partials       21       24       +3     
Impacted Files Coverage Δ
cloudpickle/compat.py 70.00% <0.00%> (-30.00%) ⬇️
cloudpickle/cloudpickle_fast.py 80.67% <0.00%> (-16.26%) ⬇️
cloudpickle/cloudpickle.py 88.00% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f758eb3...72b6f61. Read the comment docs.

@ogrisel
Copy link
Contributor Author

ogrisel commented May 20, 2022

Apparently this is caused by this error when installing the dev branch of distributed:

ERROR: Ignored the following versions that require a different python version: 2022.2.1 Requires-Python >=3.8; 2022.3.0 Requires-Python >=3.8; 2022.4.0 Requires-Python >=3.8; 2022.4.1 Requires-Python >=3.8; 2022.4.2 Requires-Python >=3.8; 2022.5.0 Requires-Python >=3.8
ERROR: Could not find a version that satisfies the requirement dask==2022.05.0 (from distributed) (from versions: 0.7.4.linux-x86_64, 0.7.5.linux-x86_64, 0.7.6.linux-x86_64, 0.8.1.macosx-10.5-x86_64, 0.2.0, 0.2.1, 0.2.2, 0.2.3, 0.2.4, 0.2.5, 0.2.6, 0.3.0, 0.4.0, 0.5.0, 0.6.0, 0.6.1, 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.7.4, 0.7.5, 0.7.6, 0.8.0, 0.8.1, 0.8.2, 0.9.0, 0.10.0, 0.10.1, 0.10.2, 0.11.0, 0.11.1, 0.12.0, 0.13.0rc1, 0.13.0, 0.14.0, 0.14.1, 0.14.2, 0.14.3, 0.15.0, 0.15.1, 0.15.2, 0.15.3, 0.15.4, 0.16.0, 0.16.1, 0.17.0, 0.17.1, 0.17.2, 0.17.3, 0.17.4, 0.17.5, 0.18.0, 0.18.1, 0.18.2, 0.19.0, 0.19.1, 0.19.2, 0.19.3, 0.19.4, 0.20.0, 0.20.1, 0.20.2, 1.0.0, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4, 1.1.5, 1.2.0, 1.2.1, 1.2.2, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.5.2, 2.6.0, 2.7.0, 2.8.0, 2.8.1, 2.9.0, 2.9.1, 2.9.2, 2.10.0, 2.10.1, 2.11.0, 2.12.0, 2.13.0, 2.14.0, 2.15.0, 2.16.0, 2.17.0, 2.17.1, 2.17.2, 2.18.0, 2.18.1, 2.19.0, 2.20.0, 2.21.0, 2.22.0, 2.23.0, 2.24.0, 2.25.0, 2.26.0, 2.27.0, 2.28.0, 2.29.0, 2.30.0, 2020.12.0, 2021.1.0, 2021.1.1, 2021.2.0, 2021.3.0, 2021.3.1, 2021.4.0, 2021.4.1, 2021.5.0, 2021.5.1, 2021.6.0, 2021.6.1, 2021.6.2, 2021.7.0, 2021.7.1, 2021.7.2, 2021.8.0, 2021.8.1, 2021.9.0, 2021.9.1, 2021.10.0, 2021.11.0, 2021.11.1, 2021.11.2, 2021.12.0, 2022.1.0, 2022.1.1, 2022.2.0)
ERROR: No matching distribution found for dask==2022.05.0

We probably need to upgrade the Python version to run the distributed tests.

@ogrisel
Copy link
Contributor Author

ogrisel commented May 20, 2022

The 3.11 failure will be fixed in a concurrent PR.

@ogrisel ogrisel changed the title Debug downstream CI Fix downstream CI May 20, 2022
@ogrisel
Copy link
Contributor Author

ogrisel commented May 20, 2022

There are a couple of failing tests in distributed, I am not sure whether they are related to cloudpickle or not. Any idea @jakirkham or @mrocklin?

I will merge this anyway to fix the test config itself but it would be great to know what to do to fix the failing tests.

@ogrisel ogrisel merged commit 2fc334d into cloudpipe:master May 20, 2022
@ogrisel ogrisel deleted the ci-debug branch May 20, 2022 13:11
@ogrisel
Copy link
Contributor Author

ogrisel commented May 20, 2022

Here is a direct link to the distributed test logs: https://github.com/cloudpipe/cloudpickle/runs/6524520561?check_suite_focus=true

@jakirkham
Copy link
Member

cc @jrbourbeau (in case anything sticks out to you)

@jakirkham
Copy link
Member

Wonder if this is related to PR ( dask/distributed#6007 )

@jakirkham
Copy link
Member

Filed issue ( dask/distributed#6403 ) to track/improve visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants