Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Python 3.11 #467

Merged
merged 1 commit into from Mar 21, 2022
Merged

Conversation

frenzymadness
Copy link
Contributor

Code objects have some new attributes. Those are related
to the enhanced exceptions with code highlighting.

I honestly don't know why the evaluation of type annotations is no longer postponed but the tests are passing now with Python 3.11a5 and alpha 6.

Fixes: #466

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #467 (47f0775) into master (9a0013e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   92.56%   92.58%   +0.02%     
==========================================
  Files           4        4              
  Lines         713      715       +2     
  Branches      156      159       +3     
==========================================
+ Hits          660      662       +2     
  Misses         32       32              
  Partials       21       21              
Impacted Files Coverage Δ
cloudpickle/cloudpickle_fast.py 96.93% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0013e...47f0775. Read the comment docs.

@ogrisel
Copy link
Contributor

ogrisel commented Mar 17, 2022

Thanks so much for the PR @frenzymadness!

Could you please try to update https://github.com/cloudpipe/cloudpickle/blob/master/.github/workflows/testing.yml#L32 to enable your new tox entry with python_version = "3.11-dev" in the GitHub actions config?

Please also document this fix in the changelog targeting the next version of cloudpickle.

Code objects have some new attributes. Those are related
to the enhanced exceptions with code highlighting.
CI job for Python 3.11 is no longer optional.
@frenzymadness
Copy link
Contributor Author

Done. I've also removed the python-nightly job as it's now part of the main testing matrix.

@ogrisel
Copy link
Contributor

ogrisel commented Mar 21, 2022

Done. I've also removed the python-nightly job as it's now part of the main testing matrix.

This is not exactly the same as github actions' "-dev" configs use alpha/beta releases and the ppa:deadsnakes/nightly config is updated on a nightly basis.

But since there is one alpha release every month on average I think it's frequent enough.

@ogrisel ogrisel merged commit f758eb3 into cloudpipe:master Mar 21, 2022
@ogrisel
Copy link
Contributor

ogrisel commented Mar 21, 2022

Thank you very much for the contrib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudpickle is not compatible with Python 3.11
2 participants