New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making "squash merging" default #459
Comments
I'm fine with squash merging being the default. |
Whoops I think #450 might be to blame for the recent not-so-informative commits : ) FWIW we've standardized on squash merging over in Dask (as @jakirkham is well aware) and I think folks have been happy with that decision. GitHub allows you to explicitly disable various types of merging on PRs (see https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests) so all but "Squash and merge" could be disabled |
Yep I dropped the ball there and clicked the merge button, which prompted this question 😅 |
Have gone ahead and made this change. Though please feel free to comment if you have thoughts here (this can always be changed again) |
After merging a PR recently, noticed other PRs here have been merged with "squash merging". Should we make this the default and/or only merge method?
No strong feelings personally. Just wondering how we can make it easier to do the expected merge behavior.
The text was updated successfully, but these errors were encountered: