Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing cloudpickle against Python 3.5 #427

Merged
merged 3 commits into from Jun 30, 2021
Merged

Conversation

pierreglaser
Copy link
Member

Python 3.5 reached end of life 9 months ago (https://www.python.org/downloads/release/python-3510/) - this PR removes the CI entry testing cloudpickle against Python 3.5.

@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #427 (386ae35) into master (a20b804) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files           4        4           
  Lines         671      671           
  Branches      137      137           
=======================================
  Hits          616      616           
  Misses         34       34           
  Partials       21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20b804...386ae35. Read the comment docs.

@pierreglaser
Copy link
Member Author

We also need to update the cloudpickle requirements in conda-forge, in the same manner as when we dropped support for Python 2 (conda-forge/cloudpickle-feedstock#36)

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update:

python_requires='>=3.5',

and delete:

'Programming Language :: Python :: 3.5',

and add an entry in the changelog?

@ogrisel ogrisel merged commit 685bf0c into master Jun 30, 2021
@ogrisel ogrisel deleted the remove-python35-ci branch June 30, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants