More post-Python 2 cleanups #345
Merged
+29
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
commented
Feb 15, 2020
| @@ -786,51 +783,6 @@ def save_instancemethod(self, obj): | |||
|
|
|||
| dispatch[types.MethodType] = save_instancemethod | |||
|
|
|||
| def save_inst(self, obj): | |||
There was a problem hiding this comment.
This as called in a Python 2 only branch of save_instancemethod.
ogrisel
commented
Feb 15, 2020
| @@ -580,6 +576,7 @@ def save_dynamic_class(self, obj): | |||
|
|
|||
| # If type overrides __dict__ as a property, include it in the type | |||
| # kwargs. In Python 2, we can't set this attribute after construction. | |||
| # XXX: can this ever happen in Python 3? If so add a test. | |||
| __dict__ = clsdict.pop('__dict__', None) | |||
| if isinstance(__dict__, property): | |||
| type_kwargs['__dict__'] = __dict__ | |||
There was a problem hiding this comment.
Not so sure about this: type_kwargs['__dict__'] = __dict__ is no longer covered by our tests.
ogrisel
force-pushed
the
more-python-2-cleanups
branch
from
6778212 to
f7922a4
Compare
|
It's sad that we cannot get the codecov reports in PR because the This is probably a design limitation of codecov. I do not see any way around as long as use github actions and codecov does not provide native upload access checks for this CI. |
|
@pierreglaser I merged to get the codecov report updated on master. The remaining commented points can be addressed in later PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some dead-code that could be removed now that we are a Python 3.5+ only project.
The coverage report still has holes that should be plugged in later PRs.