Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filter to ListXXX requests for logical separation of deployed resources #1123

Closed
lebogg opened this issue May 30, 2023 · 2 comments · Fixed by #1479
Closed

Add Filter to ListXXX requests for logical separation of deployed resources #1123

lebogg opened this issue May 30, 2023 · 2 comments · Fixed by #1479
Labels
enhancement New feature or request

Comments

@lebogg
Copy link
Member

lebogg commented May 30, 2023

Is your feature request related to a problem? Please describe.
In #1008 we added the possibility to let the engine search only for resources in a specific resource group. While this is fine in some contexts, there are two limitations:

  1. A CSP may have a different approach for logically separate environments like PROD, DEV and TEST, e.g. via tagging or simple naming (e.g., PROD_VM1)
  2. A CSP may want to do it dynamically while using the Clouditor (UI), i.e. at runtime. With the current approach you need to run a new engine instance and set the environment variable new for switching from, e.g., PROD to DEV. This is not user friendly.

Describe the solution you'd like
Add filtering for resource group, tagging and naming in all corresponding ListXXX requests

Describe alternatives you've considered
I don't have thought of an alternative but maybe there is a better solution?

@lebogg lebogg added the enhancement New feature or request label May 30, 2023
@oxisto
Copy link
Member

oxisto commented May 30, 2023

Shouldn't logically separated resources be separated into two cloud services?

@oxisto
Copy link
Member

oxisto commented Jun 20, 2023

One possible approach could be to have different discoverers with different tool ids and then filter by tool id. For this we need to:

@anatheka anatheka linked a pull request May 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants