Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Table component for dark theme #1229

Closed
tylersticka opened this issue May 20, 2021 · 0 comments · Fixed by #1242
Closed

Optimize Table component for dark theme #1229

tylersticka opened this issue May 20, 2021 · 0 comments · Fixed by #1242
Assignees
@AriannaChau
Labels
🎨 design Requires visual, UX or UI design decisions
Projects
cloudfour.com-patterns@next

Comments

@tylersticka
Copy link
Member

Observed by @Paul-Hebert in this discussion:

the table has some issues in dark mode (low contrast caption color, incorrect striped color.)

Screen Shot 2021-05-20 at 4 44 47 PM
@tylersticka tylersticka added 🎨 design Requires visual, UX or UI design decisions size:1 labels May 20, 2021
@tylersticka tylersticka added this to 🔙 Backlog in cloudfour.com-patterns@next via automation May 20, 2021
@tylersticka tylersticka moved this from 🔙 Backlog to ⏭ Up Next in cloudfour.com-patterns@next May 20, 2021
@tylersticka tylersticka mentioned this issue May 20, 2021
Merged
@AriannaChau AriannaChau mentioned this issue May 26, 2021
Merged
@AriannaChau AriannaChau moved this from ⏭ Up Next to ⌛️ In Progress in cloudfour.com-patterns@next May 26, 2021
@AriannaChau AriannaChau self-assigned this May 26, 2021
cloudfour.com-patterns@next automation moved this from ⌛️ In Progress to 🚀 Done May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AriannaChau AriannaChau

Labels
🎨 design Requires visual, UX or UI design decisions
Projects
No open projects
cloudfour.com-patterns@next
  
🚀 Done
Milestone
No milestone
2 participants
@tylersticka @AriannaChau