Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination of the default values of uaa.jwt.refresh.format (jwt) and uaa.jwt.revocable (false) results in spec-non-compliance #813

Open
peterhaochen47 opened this issue Mar 1, 2024 · 1 comment

Comments

@peterhaochen47
Copy link
Member

peterhaochen47 commented Mar 1, 2024

Based on OAuth spec, refresh tokens need to be individually revocable.

However, when we leave uaa.jwt.refresh.format (default = jwt) and uaa.jwt.revocable (default = false) to UAA-release's defaults, UAA is not compliant with this requirement.

Though it is okay to have non-spec-compliant config options for backward compatibility reason, the default UAA-release config should be spec-compliant. One solution is to set uaa.jwt.refresh.format's default to opaque. This would require a breaking change.

steps of reproduction

revoking individual refresh token does not work

uaac curl '/oauth/token/revoke/[JWT-REFRESH-TOKEN-ID]-r' -X DELETE -k

=> 404

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187154671

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants