Problems running the acceptance tests on more than one node in and existing organisation

[KevinJCross]

If there is configured an existing oranisation and there is more than one node running, when the test beforeSuite and After
Suite enable/disable the service access in the organisation it faces race conditions and willl cause test failures.

[asalan316]

Still need to be addressed. More Information needed.

[KevinJCross]

ok to be accurate .... its about this bit of code in the *_suite_test.go's

var _ = AfterSuite(func() {
	if os.Getenv("SKIP_TEARDOWN") == "true" {
		fmt.Println("Skipping Teardown...")
	} else {
		workflowhelpers.AsUser(setup.AdminUserContext(), cfg.DefaultTimeoutDuration(), func() {
			if cfg.IsServiceOfferingEnabled() && cfg.ShouldEnableServiceAccess() {
				DisableServiceAccess(cfg, setup.GetOrganizationName())
			}
		})
		setup.Teardown()
	}
})

which is run in the AfterSuite which means its run for every node! ... In the case the ORG is preset, the org is not unique for the node consequently it will be turning on and off the service access randomly during testing.

It needs to be done once per service per org ...
Either:

• each test node has its own service instance?
• or needs some concurrency control either by using a SynchronisedBeforeSuite or some other mechanism.

@silvestre thoughts? (would be nice to enable this for single org testing environments)

[KevinJCross]

@silvestre I think going down the create a new service for each node is the best idea.
Ill do a quick rework since I need to do some alterations to be able to do the --dry-run option in ginkgo.

[silvestre]

@KevinJCross : Yep, per node makes most sense.